Skip to content

feat: add disable-model-invocation to workflow commands#138

Merged
sjnims merged 1 commit intomainfrom
feat/135-add-disable-model-invocation
Dec 11, 2025
Merged

feat: add disable-model-invocation to workflow commands#138
sjnims merged 1 commit intomainfrom
feat/135-add-disable-model-invocation

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 11, 2025

Summary

Add disable-model-invocation: true to the workflow commands to prevent the SlashCommand tool from programmatically invoking these complex 8-phase workflows.

Problem

Fixes #135

The /plugin-dev:create-plugin and /plugin-dev:create-marketplace commands are complex 8-phase guided workflows designed for intentional user initiation. Without disable-model-invocation: true, Claude could accidentally invoke these commands via the SlashCommand tool during conversation.

Solution

Added disable-model-invocation: true to both command frontmatters, ensuring these workflows can only be initiated by explicit user invocation.

Alternatives Considered

  • Leave as-is: Would not address the issue and could lead to UX confusion
  • Document expected behavior: Less effective than preventing the behavior

Changes

  • plugins/plugin-dev/commands/create-plugin.md: Added disable-model-invocation: true
  • plugins/plugin-dev/commands/create-marketplace.md: Added disable-model-invocation: true

Testing

  • Markdownlint passes
  • Changes are minimal and targeted
  • Frontmatter syntax is correct

🤖 Generated with Claude Code

@sjnims @claude
feat: add disable-model-invocation to workflow commands
81159c2 
Prevent SlashCommand tool from programmatically invoking complex
8-phase workflow commands that require significant user interaction
and decision-making at multiple phases.

Commands updated:
- create-plugin.md
- create-marketplace.md

Fixes #135

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sjnims sjnims mentioned this pull request Dec 11, 2025
Closed
@sjnims sjnims self-assigned this Dec 11, 2025
@claude
Copy link
Copy Markdown

claude Bot commented Dec 11, 2025 •
edited
Loading

Claude finished @sjnims's task in 1m 1s —— View job

Review Complete

I've reviewed PR #138 and the changes look excellent. Here's my assessment:

Summary

✅ Approved - This PR correctly implements disable-model-invocation: true for the workflow commands to prevent accidental programmatic invocation.

What's Good

  1. Precise and Targeted: The changes are minimal (+2 lines total) and only affect the necessary frontmatter fields in the two workflow commands.

  2. Correct Placement: The disable-model-invocation: true field is properly added to the YAML frontmatter in both files, right after the allowed-tools field.

  3. Well-Justified: The PR description clearly explains the problem (preventing accidental SlashCommand tool invocation of complex 8-phase workflows) and why this approach is superior to alternatives.

  4. No Markdown Issues: Both files pass markdownlint with no errors or warnings.

  5. Consistent Implementation: Both /plugin-dev:create-plugin and /plugin-dev:create-marketplace commands receive the same treatment, maintaining consistency.

  6. Preserves Functionality: The change only prevents programmatic invocation via the SlashCommand tool; users can still explicitly invoke these workflows with /plugin-dev:create-plugin and /plugin-dev:create-marketplace.

Code Review

The diff shows clean additions:

plugins/plugin-dev/commands/create-plugin.md:5

+disable-model-invocation: true

plugins/plugin-dev/commands/create-marketplace.md:5

+disable-model-invocation: true

Both additions are correctly formatted YAML and placed appropriately in the frontmatter section.

Checklist Verification

Based on the PR description and my review:

  • ✅ Markdownlint passes (confirmed via local execution)
  • ✅ Changes are minimal and targeted (exactly 2 lines added)
  • ✅ Frontmatter syntax is correct (valid YAML, proper placement)
  • ✅ Addresses issue [Feature]: Add disable-model-invocation to workflow commands #135 appropriately
  • ✅ No breaking changes to user workflows
  • ✅ No documentation updates needed (this is an internal behavior change)

Final Assessment

This PR is ready to merge. The implementation correctly prevents Claude from accidentally invoking these complex guided workflows via the SlashCommand tool, while preserving the ability for users to explicitly run them. The change is well-scoped, properly implemented, and fully addresses the stated problem.

@claude claude Bot added enhancement New feature or request component:command Commands layer effort:small < 1 hour labels Dec 11, 2025
@sjnims sjnims merged commit 3572b8a into main Dec 11, 2025
8 checks passed
@sjnims sjnims deleted the feat/135-add-disable-model-invocation branch December 11, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjnims sjnims

Labels

component:command Commands layer effort:small < 1 hour enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Add disable-model-invocation to workflow commands

1 participant

@sjnims